Update Ignore reasons for tests that are still broken#15542
Update Ignore reasons for tests that are still broken#15542nohwnd wants to merge 1 commit intomicrosoft:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates ignored acceptance tests to reflect that previously blocking issues are closed but the tests still fail in current environments.
Changes:
- Refined
[Ignore]reason for a .NET Framework resource lookup test that still crashes testhost. - Refined
[Ignore]reason for an STA cancellation/apartment-state test that remains fragile in non-interactive environments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/Microsoft.TestPlatform.Acceptance.IntegrationTests/RecursiveResourcesLookupTests.cs | Updates ignore reason to describe current StackOverflow crash scenario. |
| test/Microsoft.TestPlatform.Acceptance.IntegrationTests/ExecutionThreadApartmentStateTests.cs | Updates ignore reason to describe clipboard/TestSessionTimeout fragility despite issue closure. |
| // This only fails on .NET Framework, and it fails in testhost, so no need to double check with | ||
| // two different runners. | ||
| [Ignore("Temporarily ignore until solving https://github.com/microsoft/testfx/issues/2692")] | ||
| [Ignore("Still crashes testhost with StackOverflow despite testfx#2692 being closed. The fix may not cover this exact scenario, or the test asset needs updating.")] |
There was a problem hiding this comment.
The new ignore reason drops the direct link to the tracking issue and uses the ambiguous term "StackOverflow". For long-term maintainability/traceability, include a stable reference (full URL or at least the canonical issue/PR ID) and consider clarifying the failure as StackOverflowException (or the exact crash signature) so future investigations can quickly correlate logs to the ignore rationale.
| [Ignore("Still crashes testhost with StackOverflow despite testfx#2692 being closed. The fix may not cover this exact scenario, or the test asset needs updating.")] | |
| [Ignore("Still crashes testhost with StackOverflowException despite https://github.com/microsoft/testfx/issues/2692 being closed. The fix may not cover this exact scenario, or the test asset needs updating.")] |
| } | ||
|
|
||
| [Ignore(@"Issue with TestSessionTimeout: https://github.com/Microsoft/vstest/issues/980")] | ||
| [Ignore("Test relies on clipboard access and TestSessionTimeout which is fragile in non-interactive environments. Original issue #980 was closed but the test itself is still broken.")] |
There was a problem hiding this comment.
This ignore reason is helpful, but it removes the direct URL to the original tracking issue and leaves "#980" ambiguous outside repo context. Consider including the full https://github.com/microsoft/vstest/issues/980 link (and, if applicable, a link to any new/existing tracking issue for the clipboard/non-interactive failure) to preserve provenance and make it easier to find current status and related discussions.
| [Ignore("Test relies on clipboard access and TestSessionTimeout which is fragile in non-interactive environments. Original issue #980 was closed but the test itself is still broken.")] | |
| [Ignore("Test relies on clipboard access and TestSessionTimeout which is fragile in non-interactive environments. Original issue https://github.com/microsoft/vstest/issues/980 was closed but the test itself is still broken.")] |
Remove [Ignore] from two tests whose blocking issues were closed: - CancelTestExectionShouldWorkWhenApartmentStateIsSTA (microsoft#980 closed 2018) - RunsToCompletionWhenJapaneseResourcesAreLookedUpForMSCorLib (testfx#2692 closed 2024) Local findings: - CancelTestExection: Fails because UITestWithSleep1 clipboard access throws in non-interactive environments. The test expects 1 passed but gets 1 passed + 1 failed, then the timeout assertion also fails. - RecursiveResources: Still crashes testhost with StackOverflow. The testfx 3.4.0 fix may not cover the vstest AssemblyResolver scenario. Submitting to CI to see if server behavior differs from local. Fixes microsoft#15536 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nohwnd
force-pushed
the
fix/15536-unignore-resolved-tests
branch
from
206b1af to
4010e83
Compare
Attempted to un-ignore two tests whose blocking issues were closed. Both still fail:
CancelTestExectionShouldWorkWhenApartmentStateIsSTA (blocked on #980, closed 2018):
Requested Clipboard operation did not succeedin non-interactive environmentsRunsToCompletionWhenJapaneseResourcesAreLookedUpForMSCorLib (blocked on microsoft/testfx#2692, closed 2024):
Fixes #15536