Skip to content

Fix ci build #15515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nohwnd merged 2 commits into from
Mar 19, 2026
+9 −4
Merged

Fix ci build #15515

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6de9f10
Fix ci build
nohwnd Mar 19, 2026
ad62c04
filter
nohwnd Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions eng/build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,15 +125,20 @@ if ($integrationTest -or $performanceTest -or $compatibilityTest -or $smokeTest)
}

if ($filters.Count -gt 0 -or $testParameters.Count -gt 0) {
# We have to double escape, otherwise the filter is passed as string with & in it and interpreted directly as a separate command to run.
# Ignoring exit code 8 which means no tests found, otherwise we will fail the build when we run with a filter that doesn't match any test in a project, which is common when we have multiple projects and some of them don't have certain categories of tests. https://github.com/microsoft/testfx/issues/7457
$filterString = "--filter \`"$($filters -join '&')\`" -ignore-exit-code 8"
if ($filters.Count -gt 0) {

# We have to double escape by '\"', otherwise the filter is passed as string with & in it and interpreted directly as a separate command to run.
# Ignoring exit code 8 which means no tests found, otherwise we will fail the build when we run with a filter that doesn't match any test in a project, which is common when we have multiple projects and some of them don't have certain categories of tests. https://github.com/microsoft/testfx/issues/7457
$filterString = "--filter \`"$($filters -join '&')\`""
$filterParameters = "$filterString --ignore-exit-code 8"
}

$testParameterString = ($testParameters.GetEnumerator() | ForEach-Object { "--test-parameter $($_.Key)=$($_.Value)" }) -join ' '

if (-not $PSBoundParameters.ContainsKey('properties')) {
$PSBoundParameters['properties'] = @()
}
$PSBoundParameters['properties'] += "/p:TestRunnerExternalArguments=$filterString $testParameterString"
$PSBoundParameters['properties'] += "/p:TestRunnerExternalArguments=$filterParameters $testParameterString"
}

# Call the build script provided by Arcade
Expand Down