-
Notifications
You must be signed in to change notification settings - Fork 36.4k
Add debug task #279011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add debug task #279011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a debug task to the macOS Darwin test workflow to output the result of the computeNodeModulesCacheKey.ts script to the console for debugging purposes. This runs immediately before the existing "Prepare node_modules cache key" step, which saves the same output to a file.
Key Changes
- Added a new debug step that executes
computeNodeModulesCacheKey.tswithout redirecting output to a file, allowing the cache key to be visible in workflow logs
.github/workflows/pr-darwin-test.yml
Outdated
| - name: Prepare node_modules cache key (debug) | ||
| run: node build/azure-pipelines/common/computeNodeModulesCacheKey.ts darwin $VSCODE_ARCH $(node -p process.arch) | ||
|
|
||
| - name: Prepare node_modules cache key | ||
| run: mkdir -p .build && node build/azure-pipelines/common/computeNodeModulesCacheKey.ts darwin $VSCODE_ARCH $(node -p process.arch) > .build/packagelockhash |
Copilot
AI
Nov 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This debug task runs the same script twice in succession, which adds time to the CI pipeline. If this is temporary debugging code, consider removing it before merging. If permanent, consider adding a comment explaining why the debug output is needed or consolidating it with the actual cache key preparation step using tee to both display and save the output: node build/azure-pipelines/common/computeNodeModulesCacheKey.ts darwin $VSCODE_ARCH $(node -p process.arch) | tee .build/packagelockhash.
| - name: Prepare node_modules cache key (debug) | |
| run: node build/azure-pipelines/common/computeNodeModulesCacheKey.ts darwin $VSCODE_ARCH $(node -p process.arch) | |
| - name: Prepare node_modules cache key | |
| run: mkdir -p .build && node build/azure-pipelines/common/computeNodeModulesCacheKey.ts darwin $VSCODE_ARCH $(node -p process.arch) > .build/packagelockhash | |
| - name: Prepare node_modules cache key | |
| run: mkdir -p .build && node build/azure-pipelines/common/computeNodeModulesCacheKey.ts darwin $VSCODE_ARCH $(node -p process.arch) | tee .build/packagelockhash |
No description provided.