Skip to content

Conversation

@lszomoru
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings November 23, 2025 07:14
@lszomoru lszomoru enabled auto-merge (squash) November 23, 2025 07:14
@lszomoru lszomoru self-assigned this Nov 23, 2025
Copilot finished reviewing on behalf of lszomoru November 23, 2025 07:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a debug task to the macOS Darwin test workflow to output the result of the computeNodeModulesCacheKey.ts script to the console for debugging purposes. This runs immediately before the existing "Prepare node_modules cache key" step, which saves the same output to a file.

Key Changes

  • Added a new debug step that executes computeNodeModulesCacheKey.ts without redirecting output to a file, allowing the cache key to be visible in workflow logs

Comment on lines 34 to 38
- name: Prepare node_modules cache key (debug)
run: node build/azure-pipelines/common/computeNodeModulesCacheKey.ts darwin $VSCODE_ARCH $(node -p process.arch)

- name: Prepare node_modules cache key
run: mkdir -p .build && node build/azure-pipelines/common/computeNodeModulesCacheKey.ts darwin $VSCODE_ARCH $(node -p process.arch) > .build/packagelockhash
Copy link

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This debug task runs the same script twice in succession, which adds time to the CI pipeline. If this is temporary debugging code, consider removing it before merging. If permanent, consider adding a comment explaining why the debug output is needed or consolidating it with the actual cache key preparation step using tee to both display and save the output: node build/azure-pipelines/common/computeNodeModulesCacheKey.ts darwin $VSCODE_ARCH $(node -p process.arch) | tee .build/packagelockhash.

Suggested change
- name: Prepare node_modules cache key (debug)
run: node build/azure-pipelines/common/computeNodeModulesCacheKey.ts darwin $VSCODE_ARCH $(node -p process.arch)
- name: Prepare node_modules cache key
run: mkdir -p .build && node build/azure-pipelines/common/computeNodeModulesCacheKey.ts darwin $VSCODE_ARCH $(node -p process.arch) > .build/packagelockhash
- name: Prepare node_modules cache key
run: mkdir -p .build && node build/azure-pipelines/common/computeNodeModulesCacheKey.ts darwin $VSCODE_ARCH $(node -p process.arch) | tee .build/packagelockhash

Copilot uses AI. Check for mistakes.
@vs-code-engineering vs-code-engineering bot added this to the November 2025 milestone Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants