Skip to content

adopt IChatPullRequestContent in CreateRemoteAgentJobAction #257907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 25, 2025
+23 −18
Merged

adopt IChatPullRequestContent in CreateRemoteAgentJobAction #257907

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8ab81c
adopt IChatPullRequestContent in CreateRemoteAgentJobAction
joshspicer Jul 25, 2025
c6d36a7
add version flag
joshspicer Jul 25, 2025
eecd171
comment
joshspicer Jul 25, 2025
335ff5d
more comments
joshspicer Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 23 additions & 18 deletions src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import { toChatHistoryContent } from '../../common/chatModel.js';
import { IChatMode, IChatModeService } from '../../common/chatModes.js';
import { chatVariableLeader } from '../../common/chatParserTypes.js';
import { ChatRequestParser } from '../../common/chatRequestParser.js';
import { IChatService } from '../../common/chatService.js';
import { IChatPullRequestContent, IChatService } from '../../common/chatService.js';
import { ChatAgentLocation, ChatConfiguration, ChatModeKind, } from '../../common/constants.js';
import { ILanguageModelChatMetadata } from '../../common/languageModels.js';
import { ILanguageModelToolsService } from '../../common/languageModelToolsService.js';
Expand Down Expand Up @@ -658,31 +658,36 @@ export class CreateRemoteAgentJobAction extends Action2 {
});

// Execute the remote command
const resultMarkdown: string | undefined = await commandService.executeCommand(agent.command, {
const result: Omit<IChatPullRequestContent, 'kind'> | string | undefined = await commandService.executeCommand(agent.command, {
userPrompt,
summary: summary || userPrompt,
followup,
_version: 2,
});

let content = new MarkdownString(
resultMarkdown,
CreateRemoteAgentJobAction.markdownStringTrustedOptions
);
if (!resultMarkdown) {
content = new MarkdownString(
localize('remoteAgentError', "Coding agent session cancelled."),
CreateRemoteAgentJobAction.markdownStringTrustedOptions
);
if (result && typeof result === 'object' /* _version === 2 */) {
chatModel.acceptResponseProgress(addedRequest, { kind: 'pullRequest', ...result });
} else if (typeof result === 'string') {
chatModel.acceptResponseProgress(addedRequest, {
kind: 'markdownContent',
content: new MarkdownString(
localize('remoteAgentResponse', "Coding agent response: {0}", result),
CreateRemoteAgentJobAction.markdownStringTrustedOptions
)
});
// Extension will open up the pull request in another view
widget.clear();
} else {
chatModel.acceptResponseProgress(addedRequest, {
kind: 'markdownContent',
content: new MarkdownString(
localize('remoteAgentError', "Coding agent session cancelled."),
CreateRemoteAgentJobAction.markdownStringTrustedOptions
)
});
}

chatModel.acceptResponseProgress(addedRequest, { content, kind: 'markdownContent' });
chatModel.setResponse(addedRequest, {});
chatModel.completeResponse(addedRequest);

// Clear chat (start a new chat)
if (resultMarkdown) {
widget.clear();
}
} finally {
remoteJobCreatingKey.set(false);
}
Expand Down
Loading