Fixes #192055 avoids view refresh race condition #250239
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamodio
force-pushed
the
debt/view-id-already-registered
branch
from
749e699 to
5c22100
Compare
alexr00
reviewed
Jul 9, 2025
| private _loadingPromise: Promise<any> | undefined; | ||
| private trackAsLoading<T>(promise: Promise<T>): Promise<T> { | ||
| const chainedPromise = this._loadingPromise ? this._loadingPromise.finally(() => promise) : promise; | ||
| const last = chainedPromise.catch(() => { }).finally(() => { |
There was a problem hiding this comment.
I don't think we want to catch and ignore exception here. Can this be done without the catch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #192055
The "Element with id is already registered" message has long plagued many extensions, and I've tried to work around it the best I can in the extensions themselves, but while I've been able to get very close (employing a very similar fix) I haven't been able to avoid the race condition when calling
reveal.With these changes, I haven't been able to repo the race condition anymore, not through normal loading nor with
revealcalls.Hopefully this can land 🙏 @alexr00