Skip to content

Fix infinite loop on error in user group fetch request #21597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laurenastrid1 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

Fix infinite loop on error in user group fetch request #21597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extensions/mssql/src/azure/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ export async function fetchUserGroups(userId: string): Promise<UserGroup[]> {
nextUrl = response.data["@odata.nextLink"];
} catch (error) {
console.error("Error fetching user groups:", error);
break; // Exit the loop on error
Copy link
Member

@kburtram kburtram Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the response here; but presumably response.data["@odata.nextLink"] won't work in the next iteration?

Or in other words, if response.data["@odata.nextLink"] may work to get groups, should we set nextUrl in the catch block and try again?

Copy link
Contributor

@Benjin Benjin Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things that we need to handle here:

  1. if getting the response throws
  2. if parsing the response throws

Probably need multiple try-catch blocks in here

}
}

Expand Down
Loading