Redesign query result summary and settings by aasimkhan30 · Pull Request #21467 · microsoft/vscode-mssql

aasimkhan30 · 2026-03-05T19:02:34Z

Description

Moves out the row count, execution time and summary from the status bar to query result's own status bar. This makes the items more readable
Before:

Now:

Before: (with cell selection)

Now: (With cell selection)

Adds a new menu for important setting as it requested by many users to switch to panel view but the vscode config is not discoverable.

Code Changes Checklist

New or updated unit tests added
All existing tests pass (npm run test)
Code follows contributing guidelines
Telemetry/logging updated if relevant
No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

…ed performance and clarity

… better visibility

…ummary # Conflicts: # extensions/mssql/package.json # extensions/mssql/src/controllers/mainController.ts # extensions/mssql/src/queryResult/queryResultWebViewController.ts # localization/xliff/vscode-mssql.xlf

github-actions · 2026-03-05T19:12:30Z

PR Changes

Category	Target Branch	PR Branch	Difference
vscode-mssql VSIX	6410 KB	6411 KB	⚪ 1 KB ( 0% )
sql-database-projects VSIX	7061 KB	7061 KB	⚪ 0 KB ( 0% )
data-workspace VSIX	535 KB	535 KB	⚪ 0 KB ( 0% )

codecov-commenter · 2026-03-05T19:12:58Z

Codecov Report

❌ Patch coverage is 56.98925% with 80 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.80%. Comparing base (e120e1e) to head (322d45c).
⚠️ Report is 90 commits behind head on main.

Files with missing lines	Patch %	Lines
...nsions/mssql/src/reactviews/common/locConstants.ts	0.00%	23 Missing ⚠️
extensions/mssql/src/controllers/queryRunner.ts	0.00%	18 Missing ⚠️
...ql/src/queryResult/queryResultWebViewController.ts	80.00%	14 Missing ⚠️
...sions/mssql/src/models/sqlOutputContentProvider.ts	0.00%	10 Missing ⚠️
extensions/mssql/src/views/statusView.ts	41.66%	7 Missing ⚠️
extensions/mssql/src/queryResult/utils.ts	69.23%	4 Missing ⚠️
extensions/mssql/src/controllers/mainController.ts	25.00%	3 Missing ⚠️
...c/queryResult/queryResultWebviewPanelController.ts	0.00%	1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (56.98%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #21467      +/-   ##
==========================================
+ Coverage   72.67%   72.80%   +0.12%     
==========================================
  Files         331      331              
  Lines       98489    98424      -65     
  Branches     5462     5475      +13     
==========================================
+ Hits        71580    71660      +80     
+ Misses      26909    26764     -145

Files with missing lines	Coverage Δ
extensions/mssql/src/constants/locConstants.ts	`77.71% <ø> (+1.76%)`	⬆️
...tensions/mssql/src/sharedInterfaces/queryResult.ts	`100.00% <100.00%> (ø)`
extensions/mssql/src/sharedInterfaces/telemetry.ts	`100.00% <100.00%> (ø)`
...c/queryResult/queryResultWebviewPanelController.ts	`33.33% <0.00%> (+0.31%)`	⬆️
extensions/mssql/src/controllers/mainController.ts	`33.92% <25.00%> (-0.02%)`	⬇️
extensions/mssql/src/queryResult/utils.ts	`49.02% <69.23%> (+0.47%)`	⬆️
extensions/mssql/src/views/statusView.ts	`53.73% <41.66%> (+5.26%)`	⬆️
...sions/mssql/src/models/sqlOutputContentProvider.ts	`53.23% <0.00%> (-0.47%)`	⬇️
...ql/src/queryResult/queryResultWebViewController.ts	`50.40% <80.00%> (+7.84%)`	⬆️
extensions/mssql/src/controllers/queryRunner.ts	`69.36% <0.00%> (+0.59%)`	⬆️
... and 1 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

…n configuration changes and add unit tests for the new behavior

Copilot

Pull request overview

Copilot reviewed 19 out of 22 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

extensions/mssql/src/reactviews/pages/QueryResult/queryResultSettingsControl.tsx

localization/xliff/vscode-mssql.xlf

…ummary

…ice path

Copilot

Pull request overview

Copilot reviewed 20 out of 23 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-10T22:36:29Z

localization/xliff/vscode-mssql.xlf

+    <trans-unit id="++CODE++2ada9c77ff43c3a64eb670413987d527359f366fe2ddc314dfdfd6102df8ba07">
+      <source xml:lang="en">Results Settings</source>
+    </trans-unit>


New trans-units were added/removed in the source vscode-mssql.xlf, but the corresponding localized XLIFF files (e.g. localization/xliff/vscode-mssql.de.xlf, etc.) still contain removed entries (like “Average: {0}”) and don’t include the new ones (like “Results Settings”). Please run yarn localization and commit the updated localization/xliff/*.xlf outputs so the repo’s localization files stay in sync.

Suggested change

<trans-unit id="++CODE++2ada9c77ff43c3a64eb670413987d527359f366fe2ddc314dfdfd6102df8ba07">

<source xml:lang="en">Results Settings</source>

</trans-unit>

Copilot · 2026-03-10T22:36:30Z

extensions/mssql/src/reactviews/pages/QueryResult/queryResultSettingsControl.tsx

+                    <Switch
+                        checked={openResultsInEditorTabByDefault}
+                        onChange={(_event, data) => {
+                            void setDefaultResultLocation(data.checked);
+                        }}
+                    />


The Switch control has no accessible label. In other React views (e.g. SchemaDesigner) the Switch uses the label prop so screen readers announce what the toggle does. Please add a label (or an equivalent aria-label association) describing the setting being toggled.

…ry footer

Aasim Khan added 10 commits February 25, 2026 16:53

Add cancel connection feature with UI support and command registration

e08d138

Add translation for "Cancel Connection" in localization file

45a4231

Refactor query execution handling and update UI components for improv…

87305ca

…ed performance and clarity

Add localization entries for execution status and results in l10n files

8d3ae9c

Redesign selection metrics tooltip for improved layout and styling

1531eab

Adding settings and number column styling

b65c816

Add localization entries for results settings and query results display

e2d9b43

Redesign slickgrid row borders and improve alternating row colors for…

ad86433

… better visibility

Merge remote-tracking branch 'origin/main' into aasim/fix/redesignedS…

4e0d823

…ummary # Conflicts: # extensions/mssql/package.json # extensions/mssql/src/controllers/mainController.ts # extensions/mssql/src/queryResult/queryResultWebViewController.ts # localization/xliff/vscode-mssql.xlf

Fix localization entry for "Time" in vscode-mssql.xlf

0ca080e

Copilot AI review requested due to automatic review settings March 5, 2026 19:02

aasimkhan30 requested review from Benjin, allancascante, caohai, kburtram, laurenastrid1, lewis-sanchez, manujoseph85 and ssreerama as code owners March 5, 2026 19:02

aasimkhan30 marked this pull request as draft March 5, 2026 19:03

aasimkhan30 changed the title ~~Aasim/fix/redesigned summary~~ Redesign query result summary and settings (WIP) (Not for march) Mar 5, 2026

Copilot AI reviewed Mar 5, 2026

View reviewed changes

Implement functionality to move query results to document tab based o…

2d3e3d4

…n configuration changes and add unit tests for the new behavior

aasimkhan30 marked this pull request as ready for review March 9, 2026 20:23

Copilot AI review requested due to automatic review settings March 9, 2026 20:23

Copilot started reviewing on behalf of aasimkhan30 March 9, 2026 20:24 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

extensions/mssql/src/reactviews/pages/QueryResult/queryResultSettingsControl.tsx Show resolved Hide resolved

localization/xliff/vscode-mssql.xlf Show resolved Hide resolved

aasimkhan30 changed the title ~~Redesign query result summary and settings (WIP) (Not for march)~~ Redesign query result summary and settings Mar 9, 2026

Aasim Khan added 3 commits March 9, 2026 15:54

Merge remote-tracking branch 'origin/main' into aasim/fix/redesignedS…

7c56e29

…ummary

Refactor selection summary handling and improve localization for metrics

4ae2fda

Update localization for aggregate functions and adjust SQL Tools Serv…

652582e

…ice path

Copilot AI review requested due to automatic review settings March 10, 2026 22:30

Copilot started reviewing on behalf of aasimkhan30 March 10, 2026 22:31 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Remove unused SVG files and update color styles in query result summa…

322d45c

…ry footer

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redesign query result summary and settings#21467

Redesign query result summary and settings#21467
aasimkhan30 wants to merge 15 commits intomainfrom
aasim/fix/redesignedSummary

aasimkhan30 commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented Mar 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	<trans-unit id="++CODE++2ada9c77ff43c3a64eb670413987d527359f366fe2ddc314dfdfd6102df8ba07">
	<source xml:lang="en">Results Settings</source>
	</trans-unit>

Conversation

aasimkhan30 commented Mar 5, 2026

Description

Code Changes Checklist

Reviewers: Please read our reviewer guidelines

Uh oh!

github-actions bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Changes

Uh oh!

codecov-commenter commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Mar 5, 2026 •

edited

Loading

codecov-commenter commented Mar 5, 2026 •

edited

Loading