-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: remove Visual Studio-related files for cross-platform cleanup #13702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this file is being removed. It's still referenced in Code Samples/Fib/.vscode/tasks.json for the Windows section of tasks.json.
Thanks for the review, @sean-mcmanus! I've now removed the reference to |
"focus": false, | ||
"panel": "shared" | ||
}, | ||
"linux": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Subham-KRLX . Wouldn't this prevent this code sample from working correctly on Windows (i.e. with MinGW G++) ? I think we would want to retain the window specific arguments section.
I believe the build.cmd
file is working around a known issue with MinGW that requires its bin directory to be in path when run, in order to properly resolve dependent DLLs. It may be possible to move that work-around into the TypeScript code in order to get rid of build.cmd
. But I think we would still want to use of this code sample on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think the see the real issue here. This code sample directly uses pthreads, so does not compile on Windows. I think the ideal fix here would be for the sample to be updated to provide a Windows implementation as well.
This PR removes the
build.cmd
batch file from theCode Samples/Fib/
folder.Since this file is specific to Windows and Visual Studio environments, removing it helps streamline the repository for cross-platform development and makes it cleaner for non-Windows contributors.
This is part of a minor cleanup effort to reduce legacy or unused platform-specific files.