[vcpkg-make,ncurses,python3] Filter default options, disables curses in python #49187

dg0yt · 2026-01-01T10:37:00Z

This PR enables excluding of default configuration options via a regular expression and uses it to fix ncurses.

vcpkg_configure_make/vcpkg_make_configure are being used not only for actual autotools builds but also for packages which are loosely modeled after after autotool's configure. Some packages, such as ncurses, fail to configure with unsupported options (e.g. --docdir). OTOH they need many of the default options for robust vcpkg integration regardless of host system (e.g. --libdir). The new DEFAULT_OPTIONS_EXCLUDE <regex> option enables precise removal of unsupported options. This is much simpler and more robust than duplicating desired debug/release options for affected ports.

Fixes #49106.

Python is a package which issues warnings for default options, so it benefits from the new ``DEFAULT_OPTIONS_EXCLUDE`. But the actual fix in this PR is to reliably disable direct use curses. (It wouldn't correctly use vcpkg ncurses.) This python change might fix:
#48227 (linux), #46980 (osx)

And I finally noticed again LDFLAGS starting with -Xlinker -Xlinker -Xlinker-libpath:<vcpkg...>. Now doing the addition of -libpath:... early, and letting the existing proper transformation prepend -Xlinker...

It was always enabled. When it needs to be disabled, the effect can be achieved with DEFAULT_OPTIONS_EXCLUDE.

dg0yt · 2026-01-02T09:09:21Z

ports/python3/0012-force-disable-modules.patch

-+_curses
-+_curses_panel


This goes back to #28273, but it simply had no effect at the end of Setup:

maksetup: '_curses' was handled by previous rule. maksetup: '_curses_panel' was handled by previous rule.

In theory, it would be possible to customize Setup.local ... but it would have to be done in the build directory, and in my tests make altinstall simply overwrote it with an empty placeholder.

#28273 was for osx problems. In theory it would be possible to patch python to use vcpkg ncurses. But it seems that it would need more work to avoid system provided paths even on non-osx.

And with vcpkg readline, we pull in a binary dependency on vcpkg ncurses.

Conclusion: KISS. Disable _curses and _curses_panel, reliably.

dg0yt · 2026-01-02T09:10:06Z

ports/python3/portfile.cmake

+            py_cv_module__curses=n/a
+            py_cv_module__curses_panel=n/a
+            py_cv_module__tkinter=n/a


n/a is what is used by python configure when it disables extensions for some platforms.

dg0yt · 2026-01-02T09:17:31Z

ports/python3/portfile.cmake

    vcpkg_make_configure(
        SOURCE_PATH "${SOURCE_PATH}"
        AUTORECONF
+        DEFAULT_OPTIONS_EXCLUDE "^--disable-silent-rules|^--enable-static"


Strage coincidence, drive-by fix. Touching python3 because it stumbled over ncurses for this PR. And I found python3 complaining:

configure: WARNING: unrecognized options: --disable-silent-rules, --enable-static configure: WARNING: unrecognized options: --disable-silent-rules, --enable-static

So using the new option added by this PR...

ports/vcpkg-make/vcpkg_make_configure.cmake

ports/vcpkg-make/vcpkg_make_common.cmake

BillyONeal · 2026-01-07T19:59:24Z

ports/vcpkg-make/vcpkg_make_configure.cmake

+            z_vcpkg_make_default_path_and_configure_options(opts CONFIG "${configup}"
+                EXCLUDE_FILTER "${arg_DEFAULT_OPTIONS_EXCLUDE}"
+            )
+        elseif(arg_DEFAULT_OPTIONS_EXCLUDE OR arg_DEFAULT_OPTIONS_INCLUDE)


As far as I can see DEFAULT_OPTIONS_INCLUDE does not exist?

I think the condition that actually must be forbidden is arg_DISABLE_DEFAULT_OPTIONS + arg_DEFAULT_OPTIONS_EXCLUDE and it should probably be done near the top of the function where all the other parameter validation is.

First I added add DEFAULT_OPTIONS_INCLUDE because it the helper function had it, but then I removed it for keeping the interface simple. Now this seems to be left over.

BillyONeal · 2026-01-07T20:00:25Z

ports/vcpkg-make/vcpkg_make_common.cmake

-    if(NOT arg_AUTOMAKE)
-        vcpkg_list(APPEND opts --disable-silent-rules --verbose)
-    endif()


Note: There was only one caller of z_vcpkg_make_default_path_and_configure_options and it passed AUTOMAKE so this block was dead.

No change requested.

BillyONeal · 2026-01-07T20:02:07Z

ports/vcpkg-make/vcpkg_make_configure.cmake

        if(NOT arg_DISABLE_DEFAULT_OPTIONS)
-          z_vcpkg_make_default_path_and_configure_options(opts AUTOMAKE CONFIG "${configup}")
+            z_vcpkg_make_default_path_and_configure_options(opts CONFIG "${configup}"
+                EXCLUDE_FILTER "${arg_DEFAULT_OPTIONS_EXCLUDE}"


Can you speak to having an exclude filter rather than an include filter? It seems like the port documenting the switches that a particular configure script does support is a bit more robust than trying to exclude things it does not but I am NOT an autotools expert...

(To be clear, I'm asking for a record here in code review, I'm not asking you to change the code, I just want to understand better)

In practice, we start with default options, not with no options. And then we add was is needed for specific features/dependencies, and now we can also remove what raises warnings or errors.

Note that for ncurses, the problems really came from starting with no options. The default libdir is right in CI (lib) but not for some distros (lib64). The default options literally point at this fact. But this not something you would discover from configure --help.

BillyONeal · 2026-01-07T20:03:25Z

ports/vcpkg-make/vcpkg_make_common.cmake

    endif()

+    set(library_path_flag "${VCPKG_DETECTED_CMAKE_LIBRARY_PATH_FLAG}")
+    string(REPLACE " " "\\ " current_installed_dir_escaped "${CURRENT_INSTALLED_DIR}")


This block was just moved up so I'm not going to discuss/investigate whether this transformation is valid. No change requested.

BillyONeal · 2026-01-07T20:05:25Z

ports/ncurses/portfile.cmake

-    CONFIGURE_ENVIRONMENT_VARIABLES CFLAGS
-    DETERMINE_BUILD_TRIPLET
-    NO_ADDITIONAL_PATHS
+    DEFAULT_OPTIONS_EXCLUDE "^--docdir"


Should this interface truly be a regex or would this being a list of argument names that aren't supported make more sense? (I'm worried about future us forgetting the ^)

Without regex, this would also need to learn the split between option and value (--docdir is for --docdir=share/<port>).

The single regex makes it a little bit more distinct with regard to the actual OPTIONS.

But I have no strong opinion here. The current form has a simple implementation, and its use should not be very frequent.

BillyONeal

Request-changes only to remove the DEFAULT_OPTIONS_INCLUDE dead code.

dg0yt added 5 commits January 1, 2026 11:05

[vcpkg-make] Wire filtering of default options

851870e

[ncurses] Adopt vcpkg-make and DEFAULT_OPTIONS_EXCLUDE

82e2af7

[vcpkg-make] Remove internal AUTOMAKE option

61ae968

It was always enabled. When it needs to be disabled, the effect can be achieved with DEFAULT_OPTIONS_EXCLUDE.

[vcpkg] Remove unused ..._INCLUDE option

141a007

Fixup

8e08a45

dg0yt commented Jan 2, 2026

View reviewed changes

[python3] Reliably disable some extensions

5fd1199

dg0yt force-pushed the ncurses branch from 8baee61 to 5fd1199 Compare January 2, 2026 09:19

dg0yt marked this pull request as draft January 2, 2026 11:25

dg0yt changed the title ~~[vcpkg-make,ncurses] Adopt filtering of default options~~ [vcpkg-make,ncurses] Adopt filtering of default options [python3] Disables ncurses Jan 3, 2026

dg0yt changed the title ~~[vcpkg-make,ncurses] Adopt filtering of default options [python3] Disables ncurses~~ [vcpkg-make,ncurses] Adopt filtering of default options [python3] Disables curses Jan 3, 2026

dg0yt changed the title ~~[vcpkg-make,ncurses] Adopt filtering of default options [python3] Disables curses~~ [vcpkg-make,ncurses,python3] Filter default options, disables curses in python Jan 3, 2026

dg0yt marked this pull request as ready for review January 3, 2026 08:02

dg0yt marked this pull request as draft January 3, 2026 08:05

dg0yt commented Jan 3, 2026

View reviewed changes

ports/vcpkg-make/vcpkg_make_configure.cmake Show resolved Hide resolved

ports/vcpkg-make/vcpkg_make_common.cmake Outdated Show resolved Hide resolved

Tune

37a963e

dg0yt marked this pull request as ready for review January 3, 2026 09:28

[vcpkg-make] Fix applying -Xlinker to lib paths

1ae0155

vicroms added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jan 5, 2026

BillyONeal reviewed Jan 7, 2026

View reviewed changes

BillyONeal requested changes Jan 7, 2026

View reviewed changes

vicroms removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jan 7, 2026

vicroms marked this pull request as draft January 7, 2026 20:08

Revise default options args check

bf1e821

dg0yt marked this pull request as ready for review January 11, 2026 13:46

		+_curses
		+_curses_panel

[vcpkg-make,ncurses,python3] Filter default options, disables curses in python #49187

Are you sure you want to change the base?

[vcpkg-make,ncurses,python3] Filter default options, disables curses in python #49187

Conversation

dg0yt commented Jan 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dg0yt Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BillyONeal Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BillyONeal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dg0yt commented Jan 1, 2026 •

edited

Loading

dg0yt Jan 2, 2026 •

edited

Loading

BillyONeal Jan 7, 2026 •

edited

Loading