Skip to content

Conversation

@omartijn
Copy link
Contributor

This will change the directory that vcpkg stores its executable (either vcpkg or vcpkg.exe, depending on platform), as well as the files indicating whether or not telemetry is enabled.

Fixes issue #43904

This will change the directory that vcpkg stores its executable (either
vcpkg or vcpkg.exe, depending on platform), as well as the files
indicating whether or not telemetry is enabled.

For issue microsoft#43904
@omartijn omartijn force-pushed the support-out-of-tree-builds branch from 6fbd9ca to 648885e Compare November 14, 2025 15:37
@omartijn omartijn marked this pull request as ready for review November 14, 2025 20:14
@BillyONeal BillyONeal added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Nov 14, 2025
@BillyONeal
Copy link
Member

This is effectively a feature request in PR form; given how important it is that the given executable is matched up to the correct VCPKG_ROOT I'm not sure if we want to go here; the scenario described in #43904 seems like it would be better fixed by deploying the matching vcpkg.exe with whatever mechanism was used to deploy that VCPKG_ROOT which will avoid needing to bootstrap in the potentially racy parallel region in the first place.

}
elseif (-Not (Test-Path "$vcpkgRootDir\vcpkg.disable-metrics"))
elseif (-Not (Test-Path "$vcpkgBinaryDir\vcpkg.disable-metrics"))
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants