implement getContextNode for ForOf, ForIn, and Switch statements#4450
Open
aamoghS wants to merge 1 commit into
Open
implement getContextNode for ForOf, ForIn, and Switch statements#4450aamoghS wants to merge 1 commit into
aamoghS wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes language-service context determination for ForOfStatement, ForInStatement, and SwitchStatement nodes so getContextNode no longer returns nil, addressing failures in cross-project Find All References and Go To Definition in those syntactic contexts and bringing behavior closer to upstream TypeScript.
Changes:
- Implemented
getContextNodehandling forForOfStatementandForInStatementby returning the statement node instead ofnil. - Implemented
getContextNodehandling forSwitchStatementby returning the statement node instead ofnil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where
getContextNodereturns nil forForOfStatement,ForInStatement, andSwitchStatement, which caused cross-project Find All References and Go To Definition to fail in certain contexts. The fix aligns the Go port more closely with the original TypeScript compiler.