restore JSDoc member name check for private identifier references#4449
Open
aamoghS wants to merge 4 commits into
Open
restore JSDoc member name check for private identifier references#4449aamoghS wants to merge 4 commits into
aamoghS wants to merge 4 commits into
Conversation
aamoghS
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the language service “Find All References” token-validation logic for PrivateIdentifier nodes by reintroducing a JSDoc-related exception and adding a new isJSDocMemberName helper.
Changes:
- Adds a JSDoc member-name check for
PrivateIdentifierhandling inisValidReferencePosition. - Introduces
isJSDocMemberNameto recognize JSDoc-style member-name shapes.
Comment on lines
+2655
to
+2666
| func isJSDocMemberName(node *ast.Node) bool { | ||
| if node == nil { | ||
| return false | ||
| } | ||
| if node.Kind == ast.KindIdentifier || node.Kind == ast.KindPrivateIdentifier { | ||
| return true | ||
| } | ||
| if node.Kind == ast.KindPropertyAccessExpression { | ||
| return isJSDocMemberName(node.AsPropertyAccessExpression().Name) | ||
| } | ||
| return false | ||
| } |
Comment on lines
348
to
354
| func isValidReferencePosition(node *ast.Node, searchSymbolName string) bool { | ||
| switch node.Kind { | ||
| case ast.KindPrivateIdentifier: | ||
| // !!! | ||
| // if (isJSDocMemberName(node.Parent)) { | ||
| // return true; | ||
| // } | ||
| if isJSDocMemberName(node.Parent) { | ||
| return true | ||
| } | ||
| return len(node.Text()) == len(searchSymbolName) |
Member
|
This needs tests that show this does something; it might not due to reparsing |
Comment on lines
350
to
+353
| case ast.KindPrivateIdentifier: | ||
| // !!! | ||
| // if (isJSDocMemberName(node.Parent)) { | ||
| // return true; | ||
| // } | ||
| if isJSDocMemberName(node.Parent) { | ||
| return true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores the
isJSDocMemberNamecheck forKindPrivateIdentifierinisValidReferencePosition(), and implements the missingisJSDocMemberNamehelper function, aligning with the original TypeScript implementation.