Check embedding size consistency when opening existing databases - #65
Merged
Conversation
Co-authored-by: gvanrossum <2894642+gvanrossum@users.noreply.github.com>
Co-authored-by: gvanrossum <2894642+gvanrossum@users.noreply.github.com>
Co-authored-by: gvanrossum <2894642+gvanrossum@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add consistency check between database and embeddings
Check embedding size consistency when opening existing databases
Nov 4, 2025
Collaborator
|
Copilot you need to run black on the modified files or |
Co-authored-by: gvanrossum <2894642+gvanrossum@users.noreply.github.com>
Contributor
Author
Guido van Rossum (gvanrossum)
approved these changes
Nov 4, 2025
Guido van Rossum (gvanrossum)
approved these changes
Nov 4, 2025
Guido van Rossum (gvanrossum)
approved these changes
Nov 4, 2025
Guido van Rossum (gvanrossum)
marked this pull request as ready for review
November 4, 2025 19:10
Guido van Rossum (gvanrossum)
approved these changes
Nov 4, 2025
gvanrossum-ms
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Successfully implemented embedding consistency check between database and ConversationSettings.
Changes Made
1. Added Consistency Check (
typeagent/storage/sqlite/provider.py)_check_embedding_consistency()method that validates embedding sizes during initialization2. Test Coverage (
test/test_embedding_consistency.py)3. Documentation
4. Code Formatting
Benefits
✅ Prevents confusing NumPy shape mismatch errors at runtime
✅ Catches issues immediately during database initialization
✅ Provides clear error messages with actionable guidance
✅ Works for all code paths (demo scripts, direct API usage, etc.)
✅ No impact on empty databases or properly configured systems
✅ No security issues detected by CodeQL
Testing
Security Summary
CodeQL analysis found no security vulnerabilities in the changes.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.