Misc code cleanups - #62
Merged
Merged
Conversation
gvanrossum-ms
commented
Oct 30, 2025
gvanrossum-ms
commented
Contributor
- 365c3ca Change '!= None' to 'is not None'
- 89389d3 Lose redundant '_storage_provider_created' flag; use '_storage_provider is not None'
- 40c3b2f Streamline TextEmbeddingIndexSettings creation in sqlite/provider.py
- ba1a16a Format more folders
- 219153f Add --embedding-name arg to ingest_vtt.py
- 9813de4 Remove unused sqlite storage provider argument 'conversation_index_settings'
Guido van Rossum (gvanrossum)
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.