Misc changes - #59
Merged
Merged
Conversation
- add max_retries arg, passed to openai.AsyncOpenAI - Fix typos in model_to_embedding_size_and_envvar keys (missing -3- in names)
- Removeretry_max_attempts, retry_delay - Add max_retries - More sensible initializations - Pass max_retries to AsyncEmbeddingModel - Default batch_size to 10
gvanrossum-ms
marked this pull request as draft
October 29, 2025 00:10
Contributor
Author
|
Whoops, there are type checking errors that I need to fix later. |
Guido van Rossum (gvanrossum)
marked this pull request as ready for review
October 29, 2025 02:33
Guido van Rossum (gvanrossum)
approved these changes
Oct 29, 2025
robgruen
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest to earliest commit: