Skip to content

Remove dead extract_knowledge_for_text_batch_q function #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 1 commit into from
Apr 29, 2026
Merged

Remove dead extract_knowledge_for_text_batch_q function #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions src/typeagent/knowpro/knowledge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,25 +193,3 @@ def merge_topics(topics: list[str]) -> list[str]:
# TODO: Preserve order of first occurrence?
merged_topics = set(topics)
return list(merged_topics)


async def extract_knowledge_for_text_batch_q(
knowledge_extractor: convknowledge.KnowledgeExtractor,
text_batch: list[str],
concurrency: int = 2,
) -> list[Result[kplib.KnowledgeResponse]]:
"""Extract knowledge for a batch of text inputs using a task queue."""
raise NotImplementedError("TODO")
# TODO: BatchTask etc.
# task_batch = [BatchTask(task=text) for text in text_batch]

# await run_in_batches(
# task_batch,
# lambda text: extract_knowledge_from_text(knowledge_extractor, text),
# concurrency,
# )

# results = []
# for task in task_batch:
# results.append(task.result if task.result else Failure("No result"))
# return results
Loading