Dispose of create_async_openai_client#254
Merged
bmerkle merged 2 commits intomicrosoft:mainfrom Apr 28, 2026
Merged
Conversation
Collaborator
|
@bmerkle Can you review? Should be simple. |
bmerkle
approved these changes
Apr 28, 2026
Collaborator
bmerkle
left a comment
bmerkle
left a comment
There was a problem hiding this comment.
only one small comment.
Otherwise LGTM and can be merged
| ), | ||
| model=response.model, | ||
| content=TextContent(type="text", text=text), | ||
| model="gpt-4o", |
Collaborator
There was a problem hiding this comment.
this is now hardcoded and not used from env or response anymore. (but not really a issue)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only call site was in test_mcp_server.py. Switch that to import things from model_adapters.py.