Skip to content

set COVERAGE_PROCESS_START, which the Makefile does.#253

Merged
gvanrossum merged 2 commits intomicrosoft:mainfrom
bmerkle:bugfix-coverage-windows
Apr 25, 2026
Merged

set COVERAGE_PROCESS_START, which the Makefile does.#253
gvanrossum merged 2 commits intomicrosoft:mainfrom
bmerkle:bugfix-coverage-windows

Conversation

@bmerkle
Copy link
Copy Markdown
Collaborator

@bmerkle bmerkle commented Apr 25, 2026

Without it, subprocess coverage (spawned by pytest) isn't collected

Without it, subprocess coverage (spawned by pytest) isn't collected

Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings April 25, 2026 19:15
@bmerkle bmerkle mentioned this pull request Apr 25, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Windows make.bat coverage workflow to collect coverage from pytest-spawned subprocesses by setting COVERAGE_PROCESS_START (matching the Unix Makefile behavior).

Changes:

  • Set COVERAGE_PROCESS_START before running coverage run -m pytest in make.bat.
  • Clear COVERAGE_PROCESS_START after the coverage report is generated.

Comment thread make.bat Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@bmerkle
Copy link
Copy Markdown
Collaborator Author

bmerkle commented Apr 25, 2026

@gvanrossum please merge

@gvanrossum gvanrossum merged commit 3bd1353 into microsoft:main Apr 25, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants