feature: enable manual rollback #381
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfjelds
commented
Dec 5, 2025
bfjelds
commented
Dec 5, 2025
bfjelds
commented
Dec 5, 2025
bfjelds
commented
Dec 5, 2025
bfjelds
commented
Dec 5, 2025
bfjelds
commented
Dec 5, 2025
bfjelds
commented
Dec 5, 2025
Member
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bfjelds
force-pushed
the
user/bfjelds/manual-rollback
branch
from
5fc0ede to
08fe5bd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bfjelds
force-pushed
the
user/bfjelds/manual-rollback
branch
2 times, most recently
from
be43d26 to
aceb17f
Compare
bfjelds
commented
Dec 18, 2025
Member
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bfjelds
commented
Dec 18, 2025
bfjelds
commented
Dec 18, 2025
bfjelds
force-pushed
the
user/bfjelds/manual-rollback
branch
from
fe859c1 to
55f30c1
Compare
Member
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bfjelds
force-pushed
the
user/bfjelds/manual-rollback
branch
from
2b62edf to
01e34cb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 46 out of 47 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
tools/storm/rollback/utils/config/config.go:1
- The
DebugPasswordfield was removed but is still referenced in helper.go line 12 when creating the Host Configuration. This will cause a compilation error since the field no longer exists in the TestConfig struct.
Member
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
trident rollbackto provide manual rollback. Does not allow rollback for A/B updates involving encryption currently.CLI changes
trident rollback--ab: rollback available A/B update--runtime: rollback next update if it is runtime update--check: show what next rollback is:none|ab|runtimetrident get--rollback-chain: list all available rollbacks--rollback-target: display next rollback Host ConfigurationAPI changes
Host Statustrident_version: displays version of Trident that made the Host Status entry