Repository navigation
feature: Add diagnose command #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Nikola Bojanic (nbojanic)
wants to merge
16
commits into
microsoft:main
from
nbojanic:user/nbojanic/diagnostics
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
42a927c
Add diagnostics command
nbojanic 16f23da
Add diagnose subcommand to ab_update e2e test
nbojanic 7139e60
Add trident diagnose to docs
nbojanic 83e54a8
Update diagnostics docs
nbojanic c743427
Refactor diagnose e2e test and fix when running in container
nbojanic f079d4e
Collect more info in trident diagnose
nbojanic 3e0e9a0
Update diagnose docs
nbojanic 7055cd8
refactor error handling
nbojanic 45bfe42
camel case serialized fields
nbojanic 9221fd7
fix: unnecessary pub module
nbojanic 8e311b9
Update error logging, comments, and docs
nbojanic 63826c5
fix: docs/log typo
nbojanic 6dba48b
Fix links in docs
nbojanic 09fa472
Merge remote-tracking branch 'origin/main' into user/nbojanic/diagnosβ¦
bfjelds ea03416
post-merge doc regeneration
bfjelds 62bd0db
hide hidden subcommands
bfjelds File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -99,6 +99,7 @@ pub enum Dependency { | |
| Eject, | ||
| Findmnt, | ||
| Iptables, | ||
| Journalctl, | ||
| Losetup, | ||
| Lsblk, | ||
| Lsof, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment has inconsistent spacing. There's an extra space before "system information" on line 147. It should be "including logs, and system information" or better yet, "including logs and system information" (removing the comma).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
I think the tabs can be removed