Add a version suffix to the Windows Powershell profile#20135
Open
Add a version suffix to the Windows Powershell profile#20135
Conversation
zadjii-msft
approved these changes
Apr 21, 2026
DHowett
requested changes
Apr 23, 2026
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
I have some bad news: that test in CommandlineTest might cover some load bearing use cases...
microsoft-github-policy-service
Bot
added
the
Needs-Author-Feedback
DHowett
reviewed
Apr 23, 2026
|
|
||
| // Exclude some false positives from userDefaults.json | ||
| // NOTE: we can't use the OriginTag here because it hasn't been set yet! | ||
| const bool isWinPow = _Guid.has_value() && *_Guid == DEFAULT_WINDOWS_POWERSHELL_GUID; //_Name.has_value() && til::equals_insensitive_ascii(*_Name, L"Windows PowerShell"); |
Member
There was a problem hiding this comment.
I wonder why we kept this commented out code
microsoft-github-policy-service
Bot
added
the
No-Recent-Activity
Contributor
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in the diff. Part of MSFT-59472435.
Validation Steps Performed