Skip to content

Conversation

@singhk97
Copy link

Changes can be described by this diagram:

image

@heyitsaamir
Copy link
Collaborator

heyitsaamir commented Nov 21, 2025

Now that we aren't using events for responses, I think we should make these fundamental changes:

  1. Remove process_activity from event manager and put it back in app. There is no reason for event manager to call process activity now, since the response isn't coming through event manager anymore.
  2. So pull the above in app. Inject that function in. That function can call event_manager.on_activity if it wants, but that would be a fire and forget event.
  3. The on_activity_response can also be called from the above handler then (instead of from process_message). That would clean up that architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants