Python: Fix Ollama settings issue with structured outputs - #12355 #12386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
github-actions
bot
changed the title
|
Hi @xyang2013, thanks for creating a PR for this. You'll want to make sure you properly set up your dev env so that you can install the pre-commit hooks. This will ensure that all checks have passed locally - like ruff and others. You can follow our setup guide here: https://github.com/microsoft/semantic-kernel/blob/main/python/DEV_SETUP.md#using-uv. There are also some unit tests failing: https://github.com/microsoft/semantic-kernel/actions/runs/15460655067/job/43533345701?pr=12386#step:5:604. Please have a look, thank you. |
|
Thanks, @moonbox3. I’ll take a look at the documentation later. Does that mean I need to update not only the Ollama settings file but also the associated unit tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue heading:
Python: New Feature: OllamaChatPromptExecutionSettings does not support structured outputs #12355
Link:
#12355