-
Notifications
You must be signed in to change notification settings - Fork 643
feat: upgrade minimatch to v10.0.3 #5291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade minimatch to v10.0.3 #5291
Conversation
- Update minimatch dependency from ~3.0.3 to 10.0.3 across monorepo - Update @types/minimatch from 3.0.5 to 6.0.0 - Fix breaking API changes: switch from default import to named import - api-extractor: `import minimatch from 'minimatch'` → `import { minimatch } from 'minimatch'` - webpack4-localization-plugin: same import pattern update - Centralize version management via common-versions.json preferredVersions - Update lock files and repo state hashes for both subspaces Breaking change: minimatch v10 uses named exports instead of default export
@microsoft-github-policy-service agree company="Vidos Ltd" |
@microsoft-github-policy-service agree company="Vidos Ltd" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need @types/minimatch
at all anymore, but otherwise this looks fine.
- minimatch v10 renamed IMinimatch interface to Minimatch class - Update type annotations to use the new class name
Summary
This PR upgrades the minimatch dependency from ~3.0.3 to 10.0.3 across the entire Rush monorepo to address a Regular Expression Denial of Service (ReDoS) vulnerability in the underlying brace-expansion dependency.
🔒 Security Issue
Vulnerability: GHSA-v6h2-p8h4-qcjw - CVE-2025-5889
Severity: Low (CVSS 1.3/10)
Impact: ReDoS vulnerability in brace-expansion dependency used by older versions of minimatch
The vulnerability affects the brace-expansion package versions:
Details
Dependency Updates
API Breaking Changes Fixed
Minimatch v10 introduced breaking changes in its export structure. Updated import statements:
Before (v3):
import minimatch from 'minimatch';
After (v10):
import { minimatch } from 'minimatch';
Files Updated
Lock files and repo state hashes updated
Configuration Management
How it was tested