-
Notifications
You must be signed in to change notification settings - Fork 662
[rush-lib] Add autoInstallPeers in pnpm-config #4379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
@iclanton @D4N14L @dmichon-msft Should Rush instead default to
|
octogonz
reviewed
Oct 3, 2023
common/changes/@microsoft/rush/chao-auto-install-peers_2023-10-03-20-48.json
Outdated
Show resolved
Hide resolved
octogonz
reviewed
Oct 3, 2023
octogonz
reviewed
Oct 4, 2023
octogonz
reviewed
Oct 4, 2023
common/changes/@microsoft/rush/chao-auto-install-peers_2023-10-03-20-48.json
Outdated
Show resolved
Hide resolved
octogonz
reviewed
Oct 4, 2023
octogonz
approved these changes
Oct 6, 2023
Collaborator
|
🚀 This feature was released with Rush 5.109.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PNPM8 changes the default value for
auto-install-peerssetting. It is default to true inPNPM8
In this PR, we want to provide a option inside
pnpm-config.jsonto let user overwriteauto-install-peerssetting easily.Details
If user set auto-install-peers in
pnpm-config.jsononly, use the value inpnpm-config.jsonIf user set auto-install-peers in
pnpm-config.jsonand.npmrc, use the value inpnpm-config.json, and output a warning messageIf user set auto-install-peers in
.npmrconly, do nothing, let pnpm handle itIf user does not set auto-install-peers in both
pnpm-config.jsonand.npmrc, rush will default it tofalseHow it was tested
Manually tested on rush-example repo.
Impacted documentation
N/A