chore(ebpf): update bpf header files #1928
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the bpf header files, as well as introduce Make commands to help updating these files in the future. Also update the Dockerfile for building the agent and generating Go codes. Signed-off-by: Quang Nguyen <[email protected]>
timraymond
reviewed
Nov 12, 2025
Member
timraymond
left a comment
timraymond
left a comment
There was a problem hiding this comment.
I'm going to assume that the Makefile and the Dockerfiles should be the prime focus of reviews here... and the others are just generated from those. Is that right, or is there anything else that should have eyes on it?
| ARG VERSION | ||
| ENV GOARCH=${GOARCH} | ||
| ENV GOOS=${GOOS} | ||
| ENV CGO_ENABLED=0 |
Member
There was a problem hiding this comment.
Would using //go:build ignore in placeholder.go remove the need to set CGO_ENABLED=0?
| RUN apt-get install -y bpftool libbpf-dev | ||
|
|
||
| RUN ln -s /usr/bin/clang-14 /usr/bin/clang | ||
| RUN tdnf install -y clang lld bpftool libbpf-devel gnupg file git make lsb-release wget |
Member
There was a problem hiding this comment.
Thank you for consolidating this step to a single layer 💯
| } | ||
|
|
||
| #ifdef ADVANCED_METRICS | ||
| #if ADVANCED_METRICS == 1 |
Member
There was a problem hiding this comment.
Do you need this line? If ADVANCED_METRICS is defined to be anything, you could consider it truthy. Just thinking of the traditional inclusion guard of:
#ifndef SOMETHING_H
#define SOMETHING_H
// ...
#endif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the bpf header files from upstream libbpf, as well as introduce Make commands to help updating these files in the future. Also update the Dockerfiles for building the agent and generating Go codes.
Description
Please provide a brief description of the changes made in this pull request.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.