fix(conntrack): fix compilation warning + fix subsequent stack size error #1927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error This patch fixes the operator precedence compilation warning when evaluating whether a packet is a SYN-ACK. This fix then introduced a stack size too large error, in which this patch also fixed by passing ct_keys by pointers instead of value to the help functions. Signed-off-by: Quang Nguyen <[email protected]>
timraymond
reviewed
Nov 12, 2025
Member
timraymond
left a comment
timraymond
left a comment
There was a problem hiding this comment.
All of the swapping of values -> pointers look fine to me (I assume the conditionals are NPE guards demanded by the verifier). Just one question left.
| // We have a SYN, we set `is_reply` to false and we provide `key` | ||
| return _ct_create_new_tcp_connection(p, key, observation_point, false); | ||
| } else if(tcp_handshake == TCP_SYN|TCP_ACK) { | ||
| } else if(tcp_handshake == (TCP_SYN|TCP_ACK)) { |
Member
There was a problem hiding this comment.
Just want to call out what I think is the actual operator precedence problem. My guess is that previously this was being evaluated like (tcp_handshake == TCP_SYN) | TCP_ACK which is obviously wrong written that way, but less so given the way it was written previously. The proposed change should correct it to asserting that the handshake is a SYNACK, correct @nddq ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the operator precedence compilation warning when evaluating whether a packet is a SYN-ACK. This fix then introduced a stack size too large error, in which this patch also fixed by passing ct_keys by pointers instead of value to the helper functions.
Description
Please provide a brief description of the changes made in this pull request.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.