Skip to content

Conversation

@letv1nnn
Copy link
Contributor

@letv1nnn letv1nnn commented Oct 4, 2025

Description

Added a note in the installation documentation to include instructions for authenticating to GitHub Container Registry, before installing Retina via Helm.
This ensures users avoid credential errors when pulling images.
(my first pr)

Related Issue

This pull request is related to #631

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@letv1nnn letv1nnn requested a review from a team as a code owner October 4, 2025 00:10
@letv1nnn letv1nnn force-pushed the add-ghcr-login-instructions branch from 6681e51 to 97bd4ea Compare October 4, 2025 20:42
@ibezrukavyi ibezrukavyi enabled auto-merge October 9, 2025 15:17
@ibezrukavyi ibezrukavyi linked an issue Oct 9, 2025 that may be closed by this pull request
auto-merge was automatically disabled October 9, 2025 15:46

Head branch was pushed to by a user without write access

@letv1nnn letv1nnn force-pushed the add-ghcr-login-instructions branch from 97bd4ea to 55d5528 Compare October 9, 2025 15:46
@letv1nnn letv1nnn changed the title included instructions to docker login to access ghcr (#631) docs: included instructions to docker login to access ghcr Oct 9, 2025
@ibezrukavyi ibezrukavyi added this pull request to the merge queue Oct 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 9, 2025
@ibezrukavyi ibezrukavyi added this pull request to the merge queue Oct 9, 2025
Merged via the queue into microsoft:main with commit 301dffd Oct 9, 2025
31 of 32 checks passed
agrawaliti pushed a commit to agrawaliti/retina that referenced this pull request Oct 22, 2025
…#1891)

# Description

Added a note in the installation documentation to include instructions
for authenticating to GitHub Container Registry, before installing
Retina via Helm.
This ensures users avoid credential errors when pulling images.
(my first pr)

## Related Issue

This pull request is related to microsoft#631 

## Checklist

- [x] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [x] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [x] I have correctly attributed the author(s) of the code.
- [x] I have tested the changes locally.
- [x] I have followed the project's style guidelines.
- [x] I have updated the documentation, if necessary.
- [x] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes
made.

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.

Signed-off-by: letv1nnn <[email protected]>
Signed-off-by: letv1nnn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include instructions to docker login to access GHCR OCI repository

2 participants