Skip to content

Add children to the props for @types/react@18 #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add children to the props for @types/react@18 #192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d442147
Add children to the props for @types/react@18
ChromeQ Apr 12, 2022
b265e49
Merge branch 'microsoft:master' into master
ChromeQ Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/redux-dynamic-modules-react/src/DynamicModuleLoader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import {
} from "redux-dynamic-modules-core";

export interface IDynamicModuleLoaderProps {
/** Explicitly name children as a prop to work with @types/react@18 */
children: React.ReactNode;
/** Modules that need to be dynamically registerd */
modules: IModuleTuple;

Expand Down Expand Up @@ -186,4 +188,4 @@ class AddedModulesCleanup extends React.Component<IAddedModulesCleanupProps> {
public componentWillUnmount() {
this.props.cleanup();
}
}
}