-
Notifications
You must be signed in to change notification settings - Fork 127
Consolidate OpenQASM project loading and include handling #2512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ebe8ed
to
d9e26f4
Compare
This was referenced Jun 6, 2025
d9e26f4
to
533d9e8
Compare
orpuente-MS
approved these changes
Jun 6, 2025
minestarks
reviewed
Jun 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Posting a round of comments. Still need to review language service and pip folders
minestarks
approved these changes
Jun 6, 2025
minestarks
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2444
load_openqasm_project
method instead of multiple inconsistent approachesImportResolver
from Python interop in favor of unified project loadingcompile_to_qsharp_ast_with_config
calls withparse_and_compile_to_qsharp_ast_with_config
. With parsing, compilation, and project loading being separated, trying to clear up intent and purpose.parse_sources
utility function for handling multiple source filesDebug
andClone
derives to semantic analysis types for better tooling supportThe changes ensure consistent OpenQASM project handling across VS Code extension, Python package, WASM builds, and language service while providing better error messages and debugging capabilities for multi-file projects.