Skip to content

Enhance symlink handling in create_unknown_env for Windows compatibility #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karthiknadig merged 2 commits into from
Jan 17, 2026
+11 −2
Merged

Enhance symlink handling in create_unknown_env for Windows compatibility #280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16e061f
Enhance symlink handling in create_unknown_env for Windows compatibility
karthiknadig Jan 15, 2026
d7f2cd8
Simplify symlink handling in create_unknown_env by using extend method
karthiknadig Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions crates/pet/src/locators.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,19 @@ fn create_unknown_env(
resolved_env: ResolvedPythonEnv,
fallback_category: Option<PythonEnvironmentKind>,
) -> PythonEnvironment {
// Find all the python exes in the same bin directory.
// Combine symlinks from resolved_env (which includes the original executable path
// and the resolved path) with any additional symlinks found in the bin directory.
// This is important on Windows where scoop and similar tools use shim executables
// that redirect to the real Python installation.
let mut symlinks = resolved_env.symlinks.clone().unwrap_or_default();
if let Some(additional_symlinks) = find_symlinks(&resolved_env.executable) {
symlinks.extend(additional_symlinks);
}
symlinks.sort();
symlinks.dedup();

PythonEnvironmentBuilder::new(fallback_category)
.symlinks(find_symlinks(&resolved_env.executable))
.symlinks(Some(symlinks))
.executable(Some(resolved_env.executable))
.prefix(Some(resolved_env.prefix))
.arch(Some(if resolved_env.is64_bit {
Expand Down
Loading