Skip to content

Revert "fix(mcp): handle page crash event in Tab constructor" #40619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavelfeldman merged 1 commit into from
May 5, 2026
Merged

Revert "fix(mcp): handle page crash event in Tab constructor" #40619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/playwright-core/src/tools/backend/tab.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ export class Tab extends EventEmitter<TabEventsInterface> {
eventsHelper.addEventListener(p, 'response', response => this._handleResponse(response)),
eventsHelper.addEventListener(p, 'requestfailed', request => this._handleRequestFailed(request)),
eventsHelper.addEventListener(p, 'close', () => this._onClose()),
eventsHelper.addEventListener(p, 'crash', () => this._onClose()),
eventsHelper.addEventListener(p, 'filechooser', chooser => {
this.setModalState({
type: 'fileChooser',
Expand Down
32 changes: 0 additions & 32 deletions tests/mcp/tabs.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,35 +149,3 @@ test('reuse first tab when navigating', async ({ startClient, cdpServer, server
expect(pages.length).toBe(1);
expect(await pages[0].title()).toBe('Title');
});

test('crashed tab is removed from tabs list and server recovers', async ({ client, mcpBrowser }) => {
test.skip(mcpBrowser !== 'chromium', 'Crash via chrome://crash is chromium-only');

// Open a second tab alongside the initial one
await client.callTool({
name: 'browser_tabs',
arguments: { action: 'new' },
});

// Crash the second tab; navigation to chrome://crash throws, that's expected
await client.callTool({
name: 'browser_navigate',
arguments: { url: 'chrome://crash' },
}).catch(() => {});

// Crashed tab must be gone — only the initial tab (index 0) should remain
expect(await client.callTool({
name: 'browser_tabs',
arguments: { action: 'list' },
})).toHaveResponse({
result: `- 0: (current) [](about:blank)`,
});

// Server must recover: subsequent navigation must work without hanging
expect(await client.callTool({
name: 'browser_navigate',
arguments: { url: 'data:text/html,<body>recovered</body>' },
})).toHaveResponse({
snapshot: expect.stringContaining('recovered'),
});
});
Loading