[CP] Validate VN packet SourceCid (#6167) - #6221
Merged
Gaurav Singh (gaurav2699) merged 1 commit intoAug 11, 2026
Merged
Conversation
## Description Resolves a long-standing TODO in QuicConnRecvVerNeg that noted the VN packet's Source Connection ID should be validated against our current Destination CID. ## Testing _Do any existing tests cover this change? Are new tests needed?_ ## Documentation _Is there any documentation impact for this change?_
Guillaume Hetier (guhetier)
approved these changes
Aug 11, 2026
Gaurav Singh (gaurav2699)
merged commit Aug 11, 2026
ea4ea35
into
release/2.6
483 of 484 checks passed
Gaurav Singh (gaurav2699)
deleted the
gaurasingh/cp_validate_vn_sourcecid_2_6_copilot
branch
August 11, 2026 19:01
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/2.6 #6221 +/- ##
===============================================
- Coverage 86.17% 84.92% -1.26%
===============================================
Files 60 60
Lines 18974 18981 +7
===============================================
- Hits 16351 16119 -232
- Misses 2623 2862 +239 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves a long-standing TODO in QuicConnRecvVerNeg that noted the VN
packet's Source Connection ID should be validated against our current
Destination CID.
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?