Fix heap out-of-bounds read in OpenSSL TLS FINISHED handling - #6214
Open
Gaurav Singh (gaurav2699) wants to merge 22 commits into
Open
Fix heap out-of-bounds read in OpenSSL TLS FINISHED handling #6214Gaurav Singh (gaurav2699) wants to merge 22 commits into
Gaurav Singh (gaurav2699) wants to merge 22 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6214 +/- ##
==========================================
- Coverage 86.02% 85.56% -0.46%
==========================================
Files 60 60
Lines 18984 18986 +2
==========================================
- Hits 16331 16246 -85
- Misses 2653 2740 +87 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Anthony Rossi (anrossi)
previously approved these changes
Aug 10, 2026
Guillaume Hetier (guhetier)
previously approved these changes
Aug 12, 2026
Guillaume Hetier (guhetier)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good for the logic, I think the comments can be simplified and improved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix heap out-of-bounds read in OpenSSL TLS FINISHED handling
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?