Skip to content

Document Stateless Retry Key Generation #5258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

anrossi
Copy link
Contributor

@anrossi anrossi commented Jul 17, 2025

Description

Document the algorithm used to generate the stateless retry keys.

Testing

N/A

Documentation

That's what this is.

@anrossi anrossi added this to the Future milestone Jul 17, 2025
@anrossi anrossi requested a review from a team as a code owner July 17, 2025 07:33
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.42%. Comparing base (581b196) to head (2e9f99d).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5258      +/-   ##
==========================================
+ Coverage   85.68%   86.42%   +0.74%     
==========================================
  Files          59       59              
  Lines       18331    18331              
==========================================
+ Hits        15706    15843     +137     
+ Misses       2625     2488     -137     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

guhetier
guhetier previously approved these changes Jul 17, 2025
@guhetier
Copy link
Contributor

CI repros #5247

guhetier
guhetier previously approved these changes Jul 18, 2025
@guhetier
Copy link
Contributor

CI repros #5024 and #5246 (on slightly different test cases)


*L* is the same as the key length for the `Algorithm`.

### Example 1 - AES-GCM 256
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Making a table could make this simpler and easier to read.

Copy link
Contributor

@guhetier guhetier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with nit

@guhetier
Copy link
Contributor

Cargo failure to investigate or file a bug for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants