chore: parameterize base href for deployment and update related scripts#173
Merged
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Collaborator
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
cmaneu
pushed a commit
that referenced
this pull request
Jun 10, 2026
PR #173 replaced runtime hostname-based base href detection with a build-time hardcoded BASE_HREF, which forced the single deployed artifact to always use /moaw/. This broke serving from the moaw.dev custom domain (served at root /), where assets and routes resolved to a non-existent /moaw/ path. Restore the runtime .github.io detection so the same build works from both moaw.dev (/) and *.github.io/moaw/ (/moaw/), while still parameterizing the sub-path value via BASE_HREF (defaulting to /moaw/) so the platform can be hosted in other repositories. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameterize the base href to enable the moaw platform to be more readily hosted in other repositories.