Skip to content

Checkbox consistency detailed design PR#35

Open
chigy wants to merge 21 commits into
masterfrom
user/chigy/checkboxes
Open

Checkbox consistency detailed design PR#35
chigy wants to merge 21 commits into
masterfrom
user/chigy/checkboxes

Conversation

@chigy
Copy link
Copy Markdown
Member

@chigy chigy commented Jul 12, 2019

No description provided.

Comment thread active/checkboxes/checkbox.md Outdated
Comment thread active/checkboxes/checkbox.md Outdated
chigy and others added 2 commits July 12, 2019 09:45
Co-Authored-By: Chris Glein <26607885+chrisglein@users.noreply.github.com>
Co-Authored-By: Chris Glein <26607885+chrisglein@users.noreply.github.com>
Comment thread active/checkboxes/checkbox.md Outdated
chigy added 7 commits July 12, 2019 14:55
Made the style section go to the top because I'm writing about button style and I wanted alignment with that spec.
Updating with values verified with design.
Updated to the actually agreed visual comp of checkbox.
@chigy
Copy link
Copy Markdown
Member Author

chigy commented Jul 16, 2019

@YuliKl and @chrisglein FYI. I've updated the spec with latest visual agreement with the design.

Copy link
Copy Markdown

@mdtauk mdtauk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the Unselected Outline styles be made consistent with the Outline Button styles, if the proposed Button styles are implemented? It appears as if the Filled styles will match the Primary/Accent button styles, including pressed and hover styles.

microsoft/microsoft-ui-xaml#1054

@chigy
Copy link
Copy Markdown
Member Author

chigy commented Jul 16, 2019

Will the Unselected Outline styles be made consistent with the Outline Button styles, if the proposed Button styles are implemented? It appears as if the Filled styles will match the Primary/Accent button styles, including pressed and hover styles.

microsoft/microsoft-ui-xaml#1054

@mdtauk , I do not believe they will be made exactly the same, though they should feel coherent. That said, the actual outline style is not being looked at right now so I'm unable to answer with confidence. If you have a passion, why don't you propose checkbox/button outline style that aligns so we can take a look, perhaps?

@mdtauk
Copy link
Copy Markdown

mdtauk commented Jul 16, 2019

@mdtauk , I do not believe they will be made exactly the same, though they should feel coherent. That said, the actual outline style is not being looked at right now so I'm unable to answer with confidence. If you have a passion, why don't you propose checkbox/button outline style that aligns so we can take a look, perhaps?

I posted some thoughts in the Proposal I mentioned

button styles extended

Should there be Outlined style and Filled style for all controls including CheckBoxes? I really don't know to be honest.

comparison-3
Windows Phone 7 compared to Windows Phone 8

Both these styles have existed in the past, but were there good reasons one was swapped for the other before?

Android has Outlined and Default text fields.
image

Fabric/Fast DNA has Outlined, Default, and Primary buttons.
image

image


It strikes me that outlined buttons, with a 1px border, would feel a lot more light weight on a form or page. But Filled buttons may stand out a bit better. I don't have a firm preference for one or the other, only that Fast DNA includes all three styles, and Windows UIs have moved between filled and outlined control designs in the past, so there is scope to include both styles - if there can be a simple way to switch for devs.

And what the Windows Shell's pick, will probably influence developers choices - but until the modern Shell is in dev's or user's hands - its all just discussion and hope that the design vision comes together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants