Skip to content

Switch lock_tracing to litebox_util_log#774

Merged
jaybosamiya-ms merged 2 commits intomainfrom
jayb/lock-tracing-util-log
Apr 15, 2026
Merged

Switch lock_tracing to litebox_util_log#774
jaybosamiya-ms merged 2 commits intomainfrom
jayb/lock-tracing-util-log

Conversation

@jaybosamiya-ms
Copy link
Copy Markdown
Member

This PR switches out lock_tracing functionality away from DebugLogProvider based implementation to the #665-based logging facade, in preparation for full remove of DebugLogProvider.

It also adds a reminder to turn on LITEBOX_LOG inside dev_bench, where previously stderr showed things, but now you need to remember to do LITEBOX_LOG.

@jaybosamiya-ms jaybosamiya-ms changed the title Jayb/lock tracing util log Switch lock_tracing to litebox_util_log Apr 14, 2026
@jaybosamiya-ms jaybosamiya-ms marked this pull request as ready for review April 14, 2026 22:10
Copy link
Copy Markdown
Contributor

@CvvT CvvT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Base automatically changed from jayb/litebox-logging to main April 15, 2026 21:28
@jaybosamiya-ms jaybosamiya-ms force-pushed the jayb/lock-tracing-util-log branch from d706fb9 to aa9fc83 Compare April 15, 2026 22:01
@github-actions
Copy link
Copy Markdown

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details
--- failure trait_removed_supertrait: supertrait removed or renamed ---

Description:
A supertrait was removed from a trait. Users of the trait can no longer assume it can also be used like its supertrait.
        ref: https://doc.rust-lang.org/reference/items/traits.html#supertraits
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/trait_removed_supertrait.ron

Failed in:
  supertrait litebox::platform::DebugLogProvider of trait RawSyncPrimitivesProvider in file /home/runner/work/litebox/litebox/litebox/src/sync/mod.rs:43

@jaybosamiya-ms jaybosamiya-ms added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main with commit d841588 Apr 15, 2026
14 checks passed
@jaybosamiya-ms jaybosamiya-ms deleted the jayb/lock-tracing-util-log branch April 15, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants