Open
Conversation
Add prune_dead_observers() to Subject, called during register_observer() to eagerly clean up stale weak references. Previously dead observers were only cleaned up during notify_observers(), which could leave orphaned entries indefinitely if notifications were infrequent. Includes a test verifying that registering a new observer prunes stale entries from a previously dropped observer.
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
Member
There was a problem hiding this comment.
Generally looks fine to me, adding @CvvT as a reviewer due to greater familiarity with the event system for final approval.
Minor nit: we don't need the # Summary in the PR description, or that it was split from #743. It also does not need to document that it adds a unit test. I'll update the PR description, but just making a note.
jaybosamiya-ms
added
the
expmt:shadow-kiln
CvvT
approved these changes
Apr 13, 2026
Contributor
CvvT
left a comment
CvvT
left a comment
There was a problem hiding this comment.
This PR looks good to me, but I am not sure whether this is necessary. Did you encounter any issues because of too many stale observers?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prune stale
Weakreferences from the observer list every time a new observer is registered, preventing unbounded growth when observers are dropped without explicit removal.