Draft
Conversation
…or FreeBSD builds
Replace Linux-specific tgkill/gettid with portable pthread_kill/pthread_self for FreeBSD, allowing the signal handler integration test to run on both platforms.
CvvT
added
the
must-not-merge:prototype
This is a purely-userland platform implementation (like Linux and Windows userland) that requires std, so it should be excluded from the no_std confirmation check.
On FreeBSD, opening /dev/tunN resets the interface configuration. This adds programmatic IP configuration via socket ioctls (SIOCSIFADDR, SIOCSIFDSTADDR, SIOCSIFNETMASK, SIOCSIFFLAGS) after opening the TUN device, so tests get a properly configured interface. - Add Socket syscall number to FreeBSD syscall table - Add ioctl constants and structs (SockaddrIn, IfReq) for interface config - Add configure_tun_interface() that applies IP config via ioctls - Change FreeBSDUserland::new() to accept TunConfig instead of bare name - Re-export TunConfig from litebox_platform_multiplex - Update test code to construct TunConfig on FreeBSD
This reverts commit afd299b.
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to have freebsd userland platform but was removed while undergoing drastic changes of platform interfaces. Now that we have more stable interfaces and with the help of agents, we should be able to maintain one more platform. This PR is drafted by agent based on our previous implementation.