Skip to content

Fixing proxy port bug when using Win32 path #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fixing proxy port bug when using Win32 path #903

wants to merge 4 commits into from
+120 −27

Conversation

jasonsandlin
Copy link
Member

No description provided.

ScottMunroMS
ScottMunroMS reviewed Aug 23, 2025
View reviewed changes
Copy link

@ScottMunroMS ScottMunroMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bug fix looks fine though I think the tests could be made more robust. Not blocking but food for thought. I'll let an LHC owner provide proper approval.

ScottMunroMS
ScottMunroMS reviewed Aug 23, 2025
View reviewed changes
ScottMunroMS
ScottMunroMS reviewed Aug 23, 2025
View reviewed changes
ScottMunroMS
ScottMunroMS reviewed Aug 23, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ScottMunroMS ScottMunroMS ScottMunroMS left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonsandlin @ScottMunroMS