Skip to content

SKL 1.5.0 changes #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

SKL 1.5.0 changes #774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d463516
Fixing the decomposition bug based on skl PR #28612
ksaur May 30, 2024
2d3d402
now using skl>=1.5.0
ksaur May 30, 2024
c220604
Merge branch 'main' into kasaur/skl1.5.0
ksaur Aug 7, 2024
507b5cb
Merge branch 'main' into kasaur/skl1.5.0
ksaur Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/pythonapp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,6 @@ jobs:
- name: Install basic dependencies
run: |
python -m pip install -e .[tests] -f https://download.pytorch.org/whl/torch_stable.html
- name: Test with older SKLearn on Linux with py3.9 to check backward compatibility
if: ${{ matrix.python-version == '3.9' && startsWith(matrix.os, 'ubuntu') == true }}
run: python -m pip install scikit-learn==1.2.1 numpy==1.26.4
- name: Pin SKLearn<1.5.0 on not Linux with py3.9
if: ${{ !(matrix.python-version == '3.9' && startsWith(matrix.os, 'ubuntu') == true) }}
run: python -m pip install "scikit-learn<1.5.0" numpy==1.26.4
- name: Run basic tests without extra
run: pytest
- name: Coverage on basic tests without extra
Expand Down
1 change: 0 additions & 1 deletion hummingbird/ml/operator_converters/_decomposition_implementations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,5 @@ def __init__(self, logical_operator, x_mean, x_std, y_mean, coefficients, device

def forward(self, x):
x -= self.x_mean
x /= self.x_std
y_pred = torch.mm(x, self.coefficients).float()
return y_pred + self.y_mean
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"onnxconverter-common>=1.6.0",
"onnx<=1.16.1",
"scipy",
"scikit-learn",
"scikit-learn>=1.5.0",
"torch>1.7.0",
"psutil",
"dill",
Expand Down
Loading