Skip to content

[0029] Rename API call ConvertLinearAlgebraMatrix to ConvertLinearAlgebraMatrices #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[0029] Rename API call ConvertLinearAlgebraMatrix to ConvertLinearAlgebraMatrices #514

wants to merge 4 commits into from

Conversation

anupamachandra
Copy link
Contributor

ConvertLinearAlgebraMatrix call allows conversion of several matrices in a single call, reflect that in the call name.

amarpMSFT
amarpMSFT requested changes Jul 9, 2025
View reviewed changes
Copy link
Collaborator

@amarpMSFT amarpMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth leaving a temporary note of the old name for preview.

And at the same time the new name could be listed as: ID3D12GraphicsCommandListNN::ConvertLinearAlgebraMatrices() with a note that NN TBD when implemented.

@anupamachandra
Copy link
Contributor Author

@amarpMSFT Should we change ID3D12DevicePreview to ID3D12DeviceNN as well?

@amarpMSFT
Copy link
Collaborator

@amarpMSFT Should we change ID3D12DevicePreview to ID3D12DeviceNN as well?

yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarpMSFT amarpMSFT amarpMSFT approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
needs-triage
Projects
HLSL Triage
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anupamachandra @amarpMSFT