Conversation
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified that would block approval.
Pull request overview
Fixes Bundle authorization bypass by storing internal execution context in server-side request properties instead of forgeable HTTP headers.
Changes:
- Updated Bundle context propagation and retrieval.
- Added sequential/parallel isolation regression tests.
- Added controller tests confirming headers are ignored.
File summaries
| File | Description |
|---|---|
| src/Microsoft.Health.Fhir.Shared.Api/Features/Resources/Bundle/BundleHandler.cs | Updated as part of this pull request. |
| src/Microsoft.Health.Fhir.Shared.Api/Controllers/FhirController.cs | Updated as part of this pull request. |
| src/Microsoft.Health.Fhir.Shared.Api.UnitTests/Features/Resources/Bundle/BundleHandlerTests.cs | Updated as part of this pull request. |
| src/Microsoft.Health.Fhir.Shared.Api.UnitTests/Controllers/FhirControllerTests.cs | Updated as part of this pull request. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5827 +/- ##
==========================================
+ Coverage 78.16% 78.66% +0.50%
==========================================
Files 1017 1017
Lines 36996 36995 -1
Branches 5644 5643 -1
==========================================
+ Hits 28917 29103 +186
+ Misses 6686 6475 -211
- Partials 1393 1417 +24 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pass internal Bundle context through FhirRequestContext.Properties instead of HTTP headers, preventing forged metadata from changing authorization behavior.
Add regression tests for ignored headers and isolated contexts during sequential and parallel Bundle execution.
Related issues
Addresses BUG 206795
Testing
Additional tests and existing tests run locally.
FHIR Team Checklist
Server Change (docs)
Patch|Skip|Feature|Breaking (reason)