Skip to content

Use unified data types in LoongArch SIMD intrinsics #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Aug 9, 2025

Prior to Rust nightly-2025-08-08, LoongArch SIMD intrinsics used distinct vector types such as v4i32, v8i32, and others. Passing data between intrinsics of different types required explicit mem::transmute calls, introducing unnecessary boilerplate and complexity.

This change adopts unified m128i and m256i types for all LoongArch SIMD intrinsics, eliminating redundant conversions and simplifying cross-intrinsic data handling.

Prior to Rust `nightly-2025-08-08`, LoongArch SIMD intrinsics used distinct
vector types such as `v4i32`, `v8i32`, and others. Passing data between
intrinsics of different types required explicit `mem::transmute` calls,
introducing unnecessary boilerplate and complexity.

This change adopts unified `m128i` and `m256i` types for all LoongArch SIMD
intrinsics, eliminating redundant conversions and simplifying cross-intrinsic
data handling.
Copy link
Member

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for maintaining this code!

@lhecker lhecker enabled auto-merge (squash) August 12, 2025 11:56
@lhecker lhecker merged commit e2ea892 into microsoft:main Aug 12, 2025
3 checks passed
@heiher heiher deleted the loong-simd-types branch August 12, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants