Skip to content

Conversation

@aviadkam
Copy link

@aviadkam aviadkam commented Nov 3, 2023

Adding support for pub (Flutter, Pub.Dev) package manager.
The code parsed the pubspec.yml file

@aviadkam aviadkam requested a review from a team as a code owner November 3, 2023 14:08
@aviadkam aviadkam requested a review from amitla1 November 3, 2023 14:08
@aviadkam
Copy link
Author

aviadkam commented Nov 3, 2023

@microsoft-github-policy-service agree

@codecov
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (8fd8eb7) 74.8% compared to head (d618d27) 74.7%.

❗ Current head d618d27 differs from pull request most recent head 8d3d725. Consider uploading reports for the commit 8d3d725 to get more accurate results

Files Patch % Lines
...Detection.Contracts/TypedComponent/PubComponent.cs 44.1% 21 Missing and 3 partials ⚠️
...entDetection.Detectors/pub/PubComponentDetector.cs 90.2% 4 Missing ⚠️
...ion.Detectors/pub/PubSpecLockPackageDescription.cs 0.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #888     +/-   ##
=======================================
- Coverage   74.8%   74.7%   -0.1%     
=======================================
  Files        235     241      +6     
  Lines       9937   10053    +116     
  Branches     971     988     +17     
=======================================
+ Hits        7435    7518     +83     
- Misses      2231    2259     +28     
- Partials     271     276      +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aviadkam aviadkam requested a review from melotic November 6, 2023 20:49
@aviadkam aviadkam requested a review from melotic November 15, 2023 14:58
@annaowens
Copy link
Contributor

Hi @aviadkam, would you mind linking to some documentation on pub and its manifest format?

@aviadkam
Copy link
Author

Hi @aviadkam, would you mind linking to some documentation on pub and its manifest format?

Sure. @annaowens .
Here are some links:
https://dart.dev/tools/pub/pubspec
ttps://dart.dev/tools/pub/dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants