Skip to content

Conversation

@JamieMagee
Copy link
Member

Closes #1461

Copilot AI review requested due to automatic review settings November 18, 2025 22:11
@JamieMagee JamieMagee requested a review from a team as a code owner November 18, 2025 22:11
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.3%. Comparing base (b2822ac) to head (baabed1).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #1537    +/-   ##
======================================
  Coverage   90.3%   90.3%            
======================================
  Files        418     423     +5     
  Lines      35301   35608   +307     
  Branches    2187    2237    +50     
======================================
+ Hits       31878   32168   +290     
- Misses      2981    2986     +5     
- Partials     442     454    +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot finished reviewing on behalf of JamieMagee November 18, 2025 22:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the creating-a-new-detector.md documentation to reflect the current codebase structure and provide more comprehensive guidance for creating new detectors. The documentation has been significantly expanded from 155 lines to 415 lines with better organization, detailed code examples, and step-by-step instructions.

Key changes:

  • Restructured content with clear sections for each step of detector creation
  • Added detailed code examples for component types, detector classes, and unit tests
  • Clarified detector lifecycle methods and maturity stages
  • Improved explanations of graph construction and component registration
  • Added practical guidance for running and debugging detectors

@JamieMagee JamieMagee enabled auto-merge (squash) November 18, 2025 22:15
@JamieMagee JamieMagee merged commit f28ac75 into main Nov 18, 2025
32 checks passed
@JamieMagee JamieMagee deleted the users/jamagee/creating-a-new-detector-docs branch November 18, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation for Creating New Detector is Outdated

3 participants