Skip to content

Conversation

@FernandoRojo
Copy link
Contributor

@FernandoRojo FernandoRojo commented Oct 24, 2024

There is still no official docs for the new v9 lock if format, so this parsing logic is empirically based and will be updated as specs are released
Issue tracking v9 specs: pnpm/spec#6
Format should eventually get updated here: https://github.com/pnpm/spec/blob/master/lockfile

Includes a small refactoring to re-use code and establish consistency between lockfile parsing.

@FernandoRojo FernandoRojo requested a review from a team as a code owner October 24, 2024 04:28
@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 93.29897% with 26 lines in your changes missing coverage. Please review.

Project coverage is 89.3%. Comparing base (218b693) to head (55c6376).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ComponentDetection.Detectors/pnpm/Pnpm9Detector.cs 85.9% 5 Missing and 3 partials ⚠️
...rs/pnpm/ParsingUtilities/PnpmV5ParsingUtilities.cs 82.7% 3 Missing and 2 partials ⚠️
...pm/ParsingUtilities/PnpmParsingUtilitiesFactory.cs 80.0% 1 Missing and 2 partials ⚠️
...rs/pnpm/ParsingUtilities/PnpmV6ParsingUtilities.cs 72.7% 2 Missing and 1 partial ⚠️
...ComponentDetection.Detectors/pnpm/Pnpm6Detector.cs 66.6% 1 Missing and 2 partials ⚠️
...ComponentDetection.Detectors/pnpm/Pnpm5Detector.cs 83.3% 0 Missing and 2 partials ⚠️
.../pnpm/ParsingUtilities/PnpmParsingUtilitiesBase.cs 95.0% 0 Missing and 1 partial ⚠️
...rs/pnpm/ParsingUtilities/PnpmV9ParsingUtilities.cs 92.8% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #1283    +/-   ##
======================================
  Coverage   89.3%   89.3%            
======================================
  Files        379     387     +8     
  Lines      30108   30372   +264     
  Branches    1842    1868    +26     
======================================
+ Hits       26896   27147   +251     
- Misses      2821    2827     +6     
- Partials     391     398     +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grvillic grvillic linked an issue Oct 24, 2024 that may be closed by this pull request
@grvillic grvillic self-requested a review October 25, 2024 15:10
@github-actions
Copy link

github-actions bot commented Oct 28, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@CraigMacomber CraigMacomber mentioned this pull request Dec 2, 2024
@FernandoRojo FernandoRojo merged commit 9f24dfc into main Dec 2, 2024
22 of 25 checks passed
@FernandoRojo FernandoRojo deleted the ferojo/pnpm9Detector branch December 2, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support pnpm 9

3 participants