Skip to content

Upgrade Node20 version to 20.19.2 due to security vulnerability #5212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

terinvarghese
Copy link

@terinvarghese terinvarghese commented May 19, 2025

Context

Upgrade node js 20.x to the next non vulnerable version. Reference: https://www.tenable.com/plugins/nessus/236766


Description

Upgrade Node20 version from 2.18.2 to 2.19.2


Risk Assessment (Low / Medium / High)

2.18.3 has documentation updates and fix on root certificate updater. All changes in 2.19.0-2 are minor upgrades and all tests existing tests are passing. Hence Risk assessment is marked as Low as its a minor version upgrade of Node js.


Unit Tests Added or Updated (Yes / No)

No unit tests were modified or added. All tests of dev test script are passing. Evidence attached in comments.


Additional Testing Performed

List manual or automated tests performed beyond unit tests (e.g., integration, scenario, regression).

@terinvarghese terinvarghese requested review from a team as code owners May 19, 2025 09:34
@terinvarghese terinvarghese marked this pull request as draft May 21, 2025 07:50
@terinvarghese terinvarghese marked this pull request as ready for review May 21, 2025 08:00
@terinvarghese
Copy link
Author

@AdityaMankal-MS Can you check this PR?

@AdityaMankal-MS
Copy link
Contributor

@terinvarghese, please update the risk assessment in the PR description. Mention why the risk is considered low.
Also, please attach any detail/evidence of the Agent being tested with the new Node runtime.

@terinvarghese
Copy link
Author

terinvarghese commented May 31, 2025

@AdityaMankal-MS
Outcome of dev test command below. The trx files from Test Results folder is also attached.
_codespaces-ba333e_2025-05-31_16_55_24.trx.txt

Starting test execution, please wait...
  A total of 1 test files matched the specified pattern.
  [xUnit.net 00:00:00.7971492]   Discovering: Test
  [xUnit.net 00:00:01.3886686]   Discovered:  Test
  [xUnit.net 00:00:01.4452349]   Starting:    Test
    Passed Microsoft.VisualStudio.Services.Agent.Tests.L1.Worker.CheckoutL1Tests.NoCheckout [1 s]
    Passed Microsoft.VisualStudio.Services.Agent.Tests.L1.Worker.ConditionsL1Tests.Conditions_Failed [1 s]
    Passed Microsoft.VisualStudio.Services.Agent.Tests.L1.Worker.ConfigL1Tests.TrackingConfigsShouldBeConsistentAcrossMulticheckoutRuns [6 s]
    Passed Microsoft.VisualStudio.Services.Agent.Tests.L1.Worker.ConfigL1Tests.TrackingConfigsShouldBeConsistentAcrossRunsWithDifferentCheckouts [2 s]
    Passed Microsoft.VisualStudio.Services.Agent.Tests.L1.Worker.ConfigL1Tests.TrackingConfigsShouldBeConsistentAcrossRuns [1 s]
    Passed Microsoft.VisualStudio.Services.Agent.Tests.L1.Worker.ContainerL1Tests.StepTarget_RestrictedMode(writeToBlobstorageService: False) [1 s]
    Passed Microsoft.VisualStudio.Services.Agent.Tests.L1.Worker.ContainerL1Tests.StepTarget_RestrictedMode(writeToBlobstorageService: True) [1 s]
    Passed Microsoft.VisualStudio.Services.Agent.Tests.L1.Worker.CoreL1Tests.Test_Base_Node10(writeToBlobstorageService: False) [1 s]
    Passed Microsoft.VisualStudio.Services.Agent.Tests.L1.Worker.CoreL1Tests.Test_Base_Node10(writeToBlobstorageService: True) [1 s]
    Passed Microsoft.VisualStudio.Services.Agent.Tests.L1.Worker.CoreL1Tests.Test_Base [1 s]
  [xUnit.net 00:00:22.3371593]   Finished:    Test
    Passed Microsoft.VisualStudio.Services.Agent.Tests.L1.Worker.VariableL1Tests.SetVariable_ReadVariable(writeToBlobstorageService: True) [1 s]
    Passed Microsoft.VisualStudio.Services.Agent.Tests.L1.Worker.VariableL1Tests.SetVariable_ReadVariable(writeToBlobstorageService: False) [1 s]
  Results File: /workspaces/azure-pipelines-agent/src/Test/TestResults/_codespaces-ba333e_2025-05-31_16_57_32.trx
  
  Test Run Successful.
  Total tests: 12
       Passed: 12
   Total time: 22.8440 Seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants