fix: add explicit type validation for participants in BaseGroupChat (#7580)#7597
Open
Dev-31 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: add explicit type validation for participants in BaseGroupChat (#7580)#7597Dev-31 wants to merge 1 commit intomicrosoft:mainfrom
Dev-31 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…icrosoft#7580) Passing None, a string, an integer, or a list containing non-agent objects to any group chat constructor previously raised cryptic internal errors (e.g. TypeError: object of type 'NoneType' has no len()). This adds two isinstance guards in BaseGroupChat.__init__ before any existing checks, raising a clear TypeError that identifies the offending type or index. Applies to all subclasses (RoundRobinGroupChat, SelectorGroupChat, etc.) because they all delegate to the base class. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7580.
Passing
None, a string, an integer, or a list containing non-agent objects to any group chat constructor previously raised cryptic internal errors (e.g.TypeError: object of type 'NoneType' has no len()). This adds twoisinstanceguards inBaseGroupChat.__init__before any existing checks, raising a clearTypeErrorthat identifies the offending type or index. Applies to all subclasses (RoundRobinGroupChat,SelectorGroupChat, etc.) because they all delegate to the base class.